1.0.2-RC1: Fix the IdentityFlowProcessorVerification class #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for finding, and fixing, this issue, David! @reactive-streams/contributors Merge? |
ktoso
reviewed
Dec 7, 2017
| * The expected behaviour of the {@link Flow.Publisher} returned by this method is hand out a subscription, | ||
| * followed by signalling {@code onError} on it, as specified by Rule 1.9. | ||
| * | ||
| * If you ignore these additional tests, return {@code null} from this method. |
There was a problem hiding this comment.
If you want to ignore these additional...
ktoso
reviewed
Dec 7, 2017
| @@ -128,7 +128,7 @@ public boolean skipStochasticTests() { | |||
|
|
|||
| /** | |||
| * This is the main method you must implement in your test incarnation. | |||
| * It must create a Publisher, which simply forwards all stream elements from its upstream | |||
| * It must create a {@link Processor}, which simply forwards all stream elements from its upstream | |||
ktoso
approved these changes
Dec 7, 2017
|
Awesome, @akarnokd! @reactive-streams/contributors Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
IdentityFlowProcessorVerificationclass as it did not properly use theFlowAdaptersand required the developer to specify helper structures manually and unnecessarily.The
LockstepFlowProcessorTestwas ported as a nativeFlow.Processorimplementation to ensureIdentityFlowProcessorVerificationis properly implementable.Related: #413 (comment)